fix(binary-codec): ensure 100% compatibility with xrpl.js reference implementation#182
Merged
GuillemGarciaDev merged 6 commits intoXRPLF:binary-codec/feat/update-definitionsfrom Jan 28, 2026
Conversation
…nd add missing types
…ing between the two implems, update go behaviour to match js behaviour
12 tasks
GuillemGarciaDev
approved these changes
Jan 28, 2026
815a8b7
into
XRPLF:binary-codec/feat/update-definitions
1 of 3 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(binary-codec): ensure 100% compatibility with xrpl.js reference implementation
Description
This PR aims to fix multiple compatibility issues between the Go binary-codec/address-codec and the xrpl.js reference implementation to ensure identical encoding/decoding behavior.
Type of change
Checklist:
Changes
address-codec
binary-codec
Notes
These fixes were identified by creating compatibility tests using shared JSON fixtures from the xrpl.js test suite. The Go codec now produces identical binary output as the JavaScript reference implementation for all tested transaction